Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add readme and markdown to default lint #2489

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

maryliag
Copy link
Contributor

Add the lint checks for markdown and readme to the npm run lint command, to align the local command with what is being executed on github workflow.

Without this change the lint was taking 31s, and after it took 33s, so I think the change is acceptable.

@maryliag maryliag requested a review from a team as a code owner October 16, 2024 17:09
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (a4fcd26) to head (521e699).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2489   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         157      157           
  Lines        7734     7734           
  Branches     1591     1591           
=======================================
  Hits         7019     7019           
  Misses        715      715           

package.json Outdated Show resolved Hide resolved
@david-luna david-luna merged commit f9f5123 into open-telemetry:main Oct 17, 2024
19 checks passed
@maryliag maryliag deleted the lint branch October 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants