Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric classes have "get" instead of "is" methods #773

Closed
thisthat opened this issue Jan 17, 2020 · 0 comments · Fixed by #777
Closed

Metric classes have "get" instead of "is" methods #773

thisthat opened this issue Jan 17, 2020 · 0 comments · Fixed by #777
Assignees
@thisthat

Comments

@thisthat
Copy link
Member

Several classes that implement the metric behavior use the "get" naming convention to return a boolean value. A better naming convention would be to use "is".

Currently affected classes:
@thisthat thisthat mentioned this issue Jan 17, 2020
Merged
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-java that referenced this issue Jan 20, 2020
@thisthat
Resolve open-telemetry#773
c353848
@thisthat thisthat mentioned this issue Jan 20, 2020
Merged
bogdandrutu pushed a commit that referenced this issue Jan 21, 2020
@thisthat @bogdandrutu
Resolve #773 (#777)
180dc36
@thisthat thisthat mentioned this issue Feb 14, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisthat thisthat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing naming convention for boolean getter dynatrace-oss-contrib/opentelemetry-java
1 participant
@thisthat