Resolve #773 (#777)

open-telemetry · Jan 21, 2020 · 180dc36 · 180dc36
1 parent 03f3402
commit 180dc36
Show file tree

Hide file tree

Showing 12 changed files with 16 additions and 16 deletions.
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractCounterBuilder.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractCounterBuilder.java
@@ -32,7 +32,7 @@ public final B setMonotonic(boolean monotonic) {
     return getThis();
   }
 
-  final boolean getMonotonic() {
+  final boolean isMonotonic() {
     return this.monotonic;
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractGaugeBuilder.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractGaugeBuilder.java
@@ -32,7 +32,7 @@ public final B setMonotonic(boolean monotonic) {
     return getThis();
   }
 
-  final boolean getMonotonic() {
+  final boolean isMonotonic() {
     return this.monotonic;
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractMeasureBuilder.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractMeasureBuilder.java
@@ -32,7 +32,7 @@ public final B setAbsolute(boolean absolute) {
     return getThis();
   }
 
-  final boolean getAbsolute() {
+  final boolean isAbsolute() {
     return this.absolute;
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractObserverBuilder.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/AbstractObserverBuilder.java
@@ -32,7 +32,7 @@ public final B setMonotonic(boolean monotonic) {
     return getThis();
   }
 
-  final boolean getMonotonic() {
+  final boolean isMonotonic() {
     return this.monotonic;
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleCounter.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleCounter.java
@@ -108,7 +108,7 @@ Builder getThis() {
     @Override
     public DoubleCounter build() {
       return new SdkDoubleCounter(
-          getName(), getDescription(), getConstantLabels(), getLabelKeys(), getMonotonic());
+          getName(), getDescription(), getConstantLabels(), getLabelKeys(), isMonotonic());
     }
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleMeasure.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleMeasure.java
@@ -108,7 +108,7 @@ Builder getThis() {
     @Override
     public DoubleMeasure build() {
       return new SdkDoubleMeasure(
-          getName(), getDescription(), getConstantLabels(), getLabelKeys(), getAbsolute());
+          getName(), getDescription(), getConstantLabels(), getLabelKeys(), isAbsolute());
     }
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkLongCounter.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkLongCounter.java
@@ -107,7 +107,7 @@ Builder getThis() {
     @Override
     public LongCounter build() {
       return new SdkLongCounter(
-          getName(), getDescription(), getConstantLabels(), getLabelKeys(), getMonotonic());
+          getName(), getDescription(), getConstantLabels(), getLabelKeys(), isMonotonic());
     }
   }
 }
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkLongMeasure.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkLongMeasure.java
@@ -107,7 +107,7 @@ Builder getThis() {
     @Override
     public LongMeasure build() {
       return new SdkLongMeasure(
-          getName(), getDescription(), getConstantLabels(), getLabelKeys(), getAbsolute());
+          getName(), getDescription(), getConstantLabels(), getLabelKeys(), isAbsolute());
     }
   }
 }
diff --git a/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractCounterBuilderTest.java b/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractCounterBuilderTest.java
@@ -41,7 +41,7 @@ public void defaultValue() {
     assertThat(testMetricBuilder.getUnit()).isEqualTo("1");
     assertThat(testMetricBuilder.getLabelKeys()).isEmpty();
     assertThat(testMetricBuilder.getConstantLabels()).isEmpty();
-    assertThat(testMetricBuilder.getMonotonic()).isTrue();
+    assertThat(testMetricBuilder.isMonotonic()).isTrue();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 
@@ -50,7 +50,7 @@ public void setAndGetValues() {
     TestInstrumentBuilder testMetricBuilder =
         TestInstrumentBuilder.newBuilder(NAME).setMonotonic(false);
     assertThat(testMetricBuilder.getName()).isEqualTo(NAME);
-    assertThat(testMetricBuilder.getMonotonic()).isFalse();
+    assertThat(testMetricBuilder.isMonotonic()).isFalse();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 

diff --git a/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractGaugeBuilderTest.java b/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractGaugeBuilderTest.java
@@ -41,7 +41,7 @@ public void defaultValue() {
     assertThat(testMetricBuilder.getUnit()).isEqualTo("1");
     assertThat(testMetricBuilder.getLabelKeys()).isEmpty();
     assertThat(testMetricBuilder.getConstantLabels()).isEmpty();
-    assertThat(testMetricBuilder.getMonotonic()).isFalse();
+    assertThat(testMetricBuilder.isMonotonic()).isFalse();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 
@@ -50,7 +50,7 @@ public void setAndGetValues() {
     TestInstrumentBuilder testMetricBuilder =
         TestInstrumentBuilder.newBuilder(NAME).setMonotonic(true);
     assertThat(testMetricBuilder.getName()).isEqualTo(NAME);
-    assertThat(testMetricBuilder.getMonotonic()).isTrue();
+    assertThat(testMetricBuilder.isMonotonic()).isTrue();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 

diff --git a/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractMeasureBuilderTest.java b/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractMeasureBuilderTest.java
@@ -41,7 +41,7 @@ public void defaultValue() {
     assertThat(testMetricBuilder.getUnit()).isEqualTo("1");
     assertThat(testMetricBuilder.getLabelKeys()).isEmpty();
     assertThat(testMetricBuilder.getConstantLabels()).isEmpty();
-    assertThat(testMetricBuilder.getAbsolute()).isTrue();
+    assertThat(testMetricBuilder.isAbsolute()).isTrue();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 
@@ -50,7 +50,7 @@ public void setAndGetValues() {
     TestInstrumentBuilder testMetricBuilder =
         TestInstrumentBuilder.newBuilder(NAME).setAbsolute(false);
     assertThat(testMetricBuilder.getName()).isEqualTo(NAME);
-    assertThat(testMetricBuilder.getAbsolute()).isFalse();
+    assertThat(testMetricBuilder.isAbsolute()).isFalse();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 

diff --git a/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractObserverBuilderTest.java b/sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractObserverBuilderTest.java
@@ -42,7 +42,7 @@ public void defaultValue() {
     assertThat(testMetricBuilder.getUnit()).isEqualTo("1");
     assertThat(testMetricBuilder.getLabelKeys()).isEmpty();
     assertThat(testMetricBuilder.getConstantLabels()).isEmpty();
-    assertThat(testMetricBuilder.getMonotonic()).isFalse();
+    assertThat(testMetricBuilder.isMonotonic()).isFalse();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }
 
@@ -51,7 +51,7 @@ public void setAndGetValues() {
     TestInstrumentBuilder testMetricBuilder =
         TestInstrumentBuilder.newBuilder(NAME).setMonotonic(true);
     assertThat(testMetricBuilder.getName()).isEqualTo(NAME);
-    assertThat(testMetricBuilder.getMonotonic()).isTrue();
+    assertThat(testMetricBuilder.isMonotonic()).isTrue();
     assertThat(testMetricBuilder.build()).isInstanceOf(TestInstrument.class);
   }