Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scope attributes as identifying for Tracer #5924

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 29, 2024

Towards #3368

Pre-work: #5806

@pellared pellared changed the title sdk/trace: Make scope attributes as identifying for Tracer Make scope attributes as identifying for Tracer Oct 29, 2024
@pellared pellared marked this pull request as ready for review October 29, 2024 14:02
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (30c0f3f) to head (501aaa7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5924   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        272     272           
  Lines      22839   22841    +2     
=====================================
+ Hits       19325   19327    +2     
  Misses      3170    3170           
  Partials     344     344           

see 5 files with indirect coverage changes

@pellared pellared added this to the v1.32.0 milestone Oct 29, 2024
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the OpenTracing and OpenCensus bridges be updated as well?

key := wrappedTracerKey{
name: name,
version: c.InstrumentationVersion(),
}

cfg.tp.Tracer(scopeName, trace.WithInstrumentationVersion(Version())),

@pellared
Copy link
Member Author

pellared commented Oct 29, 2024

Should the OpenTracing and OpenCensus bridges be updated as well?

key := wrappedTracerKey{
name: name,
version: c.InstrumentationVersion(),
}

cfg.tp.Tracer(scopeName, trace.WithInstrumentationVersion(Version())),

I can look tomorrow. How about addressesing as separate PR if needed? I created #5928 for tracking.

@MrAlias
Copy link
Contributor

MrAlias commented Oct 29, 2024

SGTM

@pellared pellared merged commit 3742c54 into open-telemetry:main Oct 30, 2024
32 checks passed
@pellared pellared deleted the trace-scope-attr branch October 30, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants