-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scope attributes as identifying for Tracer #5924
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5924 +/- ##
=====================================
Coverage 84.6% 84.6%
=====================================
Files 272 272
Lines 22839 22841 +2
=====================================
+ Hits 19325 19327 +2
Misses 3170 3170
Partials 344 344 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the OpenTracing and OpenCensus bridges be updated as well?
opentelemetry-go/bridge/opentracing/provider.go
Lines 51 to 54 in 30c0f3f
key := wrappedTracerKey{ | |
name: name, | |
version: c.InstrumentationVersion(), | |
} |
cfg.tp.Tracer(scopeName, trace.WithInstrumentationVersion(Version())), |
I can look tomorrow. How about addressesing as separate PR if needed? I created #5928 for tracking. |
SGTM |
Towards #3368
Pre-work: #5806