Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTracing bridge vs scope attributes #5928

Closed
pellared opened this issue Oct 29, 2024 · 1 comment · Fixed by #5931
Closed

OpenTracing bridge vs scope attributes #5928

pellared opened this issue Oct 29, 2024 · 1 comment · Fixed by #5931
Assignees
Milestone

Comments

@pellared
Copy link
Member

pellared commented Oct 29, 2024

Should the OpenTracing and OpenCensus bridges be updated as well?

key := wrappedTracerKey{
name: name,
version: c.InstrumentationVersion(),
}

cfg.tp.Tracer(scopeName, trace.WithInstrumentationVersion(Version())),

Originally posted by @MrAlias in #5924 (review)

@pellared
Copy link
Member Author

No changes needed for go.opentelemetry.io/otel/bridge/opencensus as it only bridges OpenCensus -> OpenTelemtry. OpenCensus does not have anything resembling instrumentation scope attributes.

Updating issue title and description.

@pellared pellared changed the title OpenTracing and OpenCensus bridges vs scope attributes OpenTracing bridge vs scope attributes Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant