-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify log design docs #5077
Merged
Merged
Simplify log design docs #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
March 15, 2024 07:50
pellared
added
area:logs
Part of OpenTelemetry logs
documentation
Provides helpful information
labels
Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
=======================================
- Coverage 83.4% 83.3% -0.1%
=======================================
Files 243 243
Lines 15956 15956
=======================================
- Hits 13309 13307 -2
- Misses 2359 2361 +2
Partials 288 288 |
dmathieu
approved these changes
Mar 15, 2024
dashpole
approved these changes
Mar 15, 2024
XSAM
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:logs
Part of OpenTelemetry logs
documentation
Provides helpful information
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refer to actual code in the design docs.
After this change I believe that we would only need to update the design docs if we would:
After this change there is no need to update the design doc if we e.g. add a method to the interface or add a new option.
Why
Address #5071 (comment)
My personal experience with docs is that if you have them, they give the most benefits when they are living-documentation (updated during development). It applies to design (and architecture) docs as well. Having the docs clean makes it easy maintain them and have them up to date.
Alternative
If we prefer not maintaining these documents we should at least highlight that this is the initial design and that the document can be outdated. However, I believe that the cost of having the design docs to up to date after this change is worth the value it they could provide.