Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify log design docs #5077

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Mar 15, 2024

What

Refer to actual code in the design docs.

After this change I believe that we would only need to update the design docs if we would:

  • Make significant changes in the design (e.g. we will introduce a new type to represent ReadableLogRecord)
  • Update (add/remove/update) rejected proposals

After this change there is no need to update the design doc if we e.g. add a method to the interface or add a new option.

Why

Address #5071 (comment)

  1. Make the design doc easier to maintain (up-to-date) when we will be doing design changes.
  2. The design doc can be reused when double-checking the specification compliance before going stable.
  3. The design doc can be also helpful in making design changes (additions) after OTel Go Logs is stable.
  4. The design docs helps in onboarding future contributors.
  5. Our memory is fragile (at least mine) and searching for information in Git takes more time.

My personal experience with docs is that if you have them, they give the most benefits when they are living-documentation (updated during development). It applies to design (and architecture) docs as well. Having the docs clean makes it easy maintain them and have them up to date.

Alternative

If we prefer not maintaining these documents we should at least highlight that this is the initial design and that the document can be outdated. However, I believe that the cost of having the design docs to up to date after this change is worth the value it they could provide.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 15, 2024
@pellared pellared marked this pull request as ready for review March 15, 2024 07:50
@pellared pellared added area:logs Part of OpenTelemetry logs documentation Provides helpful information labels Mar 15, 2024
@pellared pellared self-assigned this Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (3a72c5e) to head (4cbbf15).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5077     +/-   ##
=======================================
- Coverage   83.4%   83.3%   -0.1%     
=======================================
  Files        243     243             
  Lines      15956   15956             
=======================================
- Hits       13309   13307      -2     
- Misses      2359    2361      +2     
  Partials     288     288             

see 1 file with indirect coverage changes

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pellared pellared merged commit 6fb46a1 into open-telemetry:main Mar 16, 2024
25 checks passed
@pellared pellared deleted the simpl-des-docs branch March 16, 2024 10:06
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants