-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Enabled method to the Logger #5071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5071 +/- ##
=======================================
- Coverage 83.2% 83.2% -0.1%
=======================================
Files 243 243
Lines 15910 15917 +7
=======================================
+ Hits 13249 13250 +1
- Misses 2373 2379 +6
Partials 288 288
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
March 13, 2024 19:37
pellared
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add benchmarks to the API
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
pellared
reviewed
Mar 13, 2024
XSAM
approved these changes
Mar 13, 2024
pellared
reviewed
Mar 14, 2024
cc @dashpole |
pellared
reviewed
Mar 14, 2024
pellared
approved these changes
Mar 14, 2024
dmathieu
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4995
Enabled
method to theLogger
in the log APIEnabled
method to theProcessor
in the log SDKProcessor
interfaceThis does not add tests for the
MinServerityProcessor
due to theRecord
not being implemented and there is no way to set the severity during testing currently. The plan is to follow up when that changes.TODO
Enabled
method to theLogger
opentelemetry-specification#3917).Track adding tests in a follow-up issue