Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/trace: use slices.Grow() to avoid excessive runtime.growslice() #4818

Merged
merged 18 commits into from
Jan 12, 2024
Merged

sdk/trace: use slices.Grow() to avoid excessive runtime.growslice() #4818

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
50e4fa1
sdk/trace: use slices.Grow() to avoid excessive runtime.growslice()
lizthegrey Jan 9, 2024
9fb618c
go1.20 compat
lizthegrey Jan 9, 2024
1e4fcfa
update go.mod/sum
lizthegrey Jan 9, 2024
5409f3a
Update CHANGELOG.md
lizthegrey Jan 9, 2024
b4e888e
Revert "update go.mod/sum"
lizthegrey Jan 9, 2024
bc42f63
inline slices.Grow as ensureAttributesCapacity
lizthegrey Jan 9, 2024
05f5a8d
fix comment
lizthegrey Jan 9, 2024
da77f25
add bench
lizthegrey Jan 9, 2024
af0d2a6
fix inlining
lizthegrey Jan 9, 2024
2a08289
Apply suggestions from code review
lizthegrey Jan 10, 2024
1cf32e2
add ReportAllocs
lizthegrey Jan 10, 2024
f4ba48d
Merge branch 'main' into lizf.trace-slices-grow
lizthegrey Jan 10, 2024
1dcc51f
add benchmark variations with lower limit
lizthegrey Jan 11, 2024
e954fef
bugfix: we always want to set cap, just the value is a min()
lizthegrey Jan 11, 2024
910f7cc
lint
lizthegrey Jan 11, 2024
8f974a1
Merge branch 'main' into lizf.trace-slices-grow
lizthegrey Jan 11, 2024
df9d38d
Merge branch 'main' into lizf.trace-slices-grow
lizthegrey Jan 12, 2024
867aeb8
Merge branch 'main' into lizf.trace-slices-grow
lizthegrey Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into lizf.trace-slices-grow
  • Loading branch information
@lizthegrey
lizthegrey committed Jan 10, 2024
commit f4ba48dbee68b9d0b9736ae566c1ca1dd5b597da
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Improve performance of the `(*Set).Filter` method in `go.opentelemetry.io/otel/attribute` when the passed filter does not filter out any attributes from the set. (#4774)
- `Member.String` in `go.opentelemetry.io/otel/baggage` percent-encodes only when necessary. (#4775)
- Improve `go.opentelemetry.io/otel/trace.Span`'s performance when adding multiple attributes. (#4818)
- `Property.Value` in `go.opentelemetry.io/otel/baggage` now returns a raw string instead of a percent-encoded value. (#4804)

### Fixed

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.