Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first-seen instrument name for name conflicts #4428

Merged
merged 4 commits into from
Aug 10, 2023

Merge branch 'main' into first-seen-stream-name

118569c
Select commit
Loading
Failed to load commit list.
Merged

Use first-seen instrument name for name conflicts #4428

Merge branch 'main' into first-seen-stream-name
118569c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 10, 2023 in 0s

81.2% (-0.1%) compared to b44a2bb

View this Pull Request on Codecov

81.2% (-0.1%) compared to b44a2bb

Details

Codecov Report

Merging #4428 (118569c) into main (b44a2bb) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4428     +/-   ##
=======================================
- Coverage   81.2%   81.2%   -0.1%     
=======================================
  Files        247     247             
  Lines      19996   20006     +10     
=======================================
+ Hits       16248   16256      +8     
- Misses      3405    3407      +2     
  Partials     343     343             
Files Changed Coverage Δ
sdk/metric/instrument.go 92.0% <100.0%> (+0.2%) ⬆️
sdk/metric/pipeline.go 88.5% <100.0%> (+0.2%) ⬆️

... and 1 file with indirect coverage changes