Use first-seen instrument name for name conflicts #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
=======================================
- Coverage 81.2% 81.2% -0.1%
=======================================
Files 247 247
Lines 19996 20006 +10
=======================================
+ Hits 16248 16256 +8
- Misses 3405 3407 +2
Partials 343 343
|
MrAlias
force-pushed
the
first-seen-stream-name
branch
from
c6d9c6f
to
17359d6
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Aug 9, 2023
pellared
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3835
Resolve #3653
It has been clarified at the specification level1 that instrument name conflicts need to be resolved by using the first-seen instrument name as the produced data stream name. This changes our implementation to comply with this and adds testing to prevent regression.
Footnotes
https://github.com/open-telemetry/opentelemetry-specification/issues/3539 ↩