Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.32.0 -- Revised Metric SDK (Alpha) #3184

Merged
merged 7 commits into from
Sep 19, 2022

Conversation

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #3184 (5f3f2a5) into main (fae4b90) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3184   +/-   ##
=====================================
  Coverage   77.4%   77.4%           
=====================================
  Files        158     158           
  Lines      11084   11084           
=====================================
  Hits        8583    8583           
  Misses      2306    2306           
  Partials     195     195           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 19, 2022

I didn't include a release for the OC bridge as it was removed and planned to be replaced in the next milestone. I think this is fine as the last release of the OC bridge should sill bring in the previous metric SDK code. Though, I'm not 100% this is the correct approach. Thoughts?

@MadVikingGod
Copy link
Contributor

I'm ok with this approach. It might cause a bit of churn for anyone using the opencensus metrics bridge.

The only alternative I can think of is to not release a 0.32 of the bridge and wait until it's implemented (basically pin it at 0.31 and 1.9 until then).

@MrAlias MrAlias merged commit f215b8d into open-telemetry:main Sep 19, 2022
@MrAlias MrAlias deleted the release-v0.32.0 branch September 19, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants