-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Preparation: Update metric SDK use in otelgocql #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily remove the metric SDK use while the metrictest package is being developed.
MrAlias
changed the title
Release Preparation: Remove metric SDK use in otelgocql/test
Release Preparation: Update metric SDK use in otelgocql
Sep 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2760 +/- ##
=======================================
+ Coverage 74.4% 77.4% +2.9%
=======================================
Files 145 147 +2
Lines 6707 6753 +46
=======================================
+ Hits 4993 5229 +236
+ Misses 1566 1363 -203
- Partials 148 161 +13
|
MrAlias
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
Sep 16, 2022
This comment was marked as outdated.
This comment was marked as outdated.
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 16, 2022 20:59
Aneurysm9
approved these changes
Sep 16, 2022
hanyuancheung
approved these changes
Sep 17, 2022
This was referenced Sep 18, 2022
Merged
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily remove the metric SDK in
otelgocql/test
use while the metrictest package is being developed.Update the example package in
otelgocql
to use the new metric SDK.Part of open-telemetry/opentelemetry-go#3176