Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MarshalJSON for core.Value #281

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Add MarshalJSON for core.Value #281

merged 3 commits into from
Nov 4, 2019

Conversation

clsung
Copy link
Contributor

@clsung clsung commented Nov 2, 2019

@clsung
Add MarshalJSON for core.Value
31827c9 
- fix open-telemetry#280, where stdout export will not print Attributes value from
  MessageEvents.
- add unit test for it.
@lizthegrey lizthegrey merged commit 881e51f into open-telemetry:master Nov 4, 2019
@clsung clsung deleted the key_event_json branch November 6, 2019 00:30
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@freeformz freeformz freeformz approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@pjanotti pjanotti Awaiting requested review from pjanotti

@rghetia rghetia Awaiting requested review from rghetia

@sjkaris sjkaris Awaiting requested review from sjkaris

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Stdout exporter does not print Attributes from MessageEvent
5 participants
@clsung @freeformz @lizthegrey @jmacd @pellared