Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdout exporter does not print Attributes from MessageEvent #280

Closed
clsung opened this issue Nov 2, 2019 · 0 comments · Fixed by #281
Closed

Stdout exporter does not print Attributes from MessageEvent #280

clsung opened this issue Nov 2, 2019 · 0 comments · Fixed by #281
Milestone
untracked

Comments

@clsung
Copy link
Contributor

clsung commented Nov 2, 2019

If the Span contain MessageEvent, the output will omit Attirbutes, which is array of core.KeyValue
clsung added a commit to clsung/opentelemetry-go that referenced this issue Nov 2, 2019
@clsung
Add MarshalJSON for core.Value
31827c9 
- fix open-telemetry#280, where stdout export will not print Attributes value from
  MessageEvents.
- add unit test for it.
@clsung clsung mentioned this issue Nov 2, 2019
Merged
lizthegrey pushed a commit that referenced this issue Nov 4, 2019
@clsung @lizthegrey
Add MarshalJSON for core.Value (#281)
881e51f 
- fix #280, where stdout export will not print Attributes value from
  MessageEvents.
- add unit test for it.
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Add MarshalJSON for core.Value clsung/opentelemetry-go
2 participants
@clsung @pellared