Remove the WithSDKOptions from the Jaeger exporter #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
release:1.0.0-rc.1
pkg:exporter:jaeger
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
=====================================
Coverage 78.4% 78.4%
=====================================
Files 135 135
Lines 7252 7247 -5
=====================================
- Hits 5688 5687 -1
+ Misses 1316 1315 -1
+ Partials 248 245 -3
|
MrAlias
force-pushed
the
jaeger-rm-sdk-opts
branch
from
732d52e
to
9d5aaed
Compare
paivagustavo
approved these changes
Apr 19, 2021
MrAlias
commented
Apr 20, 2021
Aneurysm9
approved these changes
Apr 20, 2021
…-go into jaeger-rm-sdk-opts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the Jaeger exporter
WithSDKOptionsOption. This option was used to set SDK options for the exporter creation convenience functions. These functions are provided as a way to easily setup or install the exporter with what are deemed reasonable SDK settings for common use cases. If the SDK needs to be configured differently, theNewRawExporterfunction and direct setup of the SDK with the desired settings should be used.Part of #1803