Lint

open-telemetry · Apr 19, 2021 · 9d5aaed · 9d5aaed
1 parent f41f985
commit 9d5aaed
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -96,7 +96,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Removed the Jaeger exporter `WithSDKOptions` `Option`.
   This option was used to set SDK options for the exporter creation convenience functions.
   These functions are provided as a way to easily setup or install the exporter with what are deemed reasonable SDK settings for common use cases.
-  If the SDK needs to be configured differently, the `NewRawExporter` function and direct setup of the SDK with the desired settings should be used. (TBD)
+  If the SDK needs to be configured differently, the `NewRawExporter` function and direct setup of the SDK with the desired settings should be used. (#1825)
 
 ## [0.19.0] - 2021-03-18
 

diff --git a/example/jaeger/go.mod b/example/jaeger/go.mod
@@ -11,7 +11,6 @@ replace (
 require (
 	go.opentelemetry.io/otel v0.19.0
 	go.opentelemetry.io/otel/exporters/trace/jaeger v0.19.0
-	go.opentelemetry.io/otel/sdk v0.19.0
 )
 
 replace go.opentelemetry.io/otel/bridge/opencensus => ../../bridge/opencensus

diff --git a/exporters/trace/jaeger/jaeger_test.go b/exporters/trace/jaeger/jaeger_test.go
@@ -258,7 +258,7 @@ func TestExporterExportSpan(t *testing.T) {
 		assert.True(t, span.SpanContext().IsValid())
 	}
 
-	tp.Shutdown(ctx)
+	require.NoError(t, tp.Shutdown(ctx))
 
 	batchesUploaded := testCollector.batchesUploaded
 	require.Len(t, batchesUploaded, 1)