Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options field from Jaeger exporter #1808

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 13, 2021

The initialization options of the exporter are not used after the Exporter is created. Stop saving them in a field.

Part of #1803

The initialization options of the exporter are not used after the
Exporter is created. Stop saving them in a field.
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #1808 (e7c4944) into main (6db20e0) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1808     +/-   ##
=======================================
- Coverage   78.6%   78.6%   -0.1%     
=======================================
  Files        134     134             
  Lines       7159    7158      -1     
=======================================
- Hits        5633    5632      -1     
  Misses      1276    1276             
  Partials     250     250             
Impacted Files Coverage Δ
exporters/trace/jaeger/jaeger.go 93.4% <100.0%> (-0.1%) ⬇️
sdk/trace/batch_span_processor.go 83.9% <0.0%> (ø)

@MrAlias MrAlias merged commit 0489060 into open-telemetry:main Apr 14, 2021
@MrAlias MrAlias deleted the jaeger-no-opts branch April 14, 2021 15:23
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants