Skip to content

Commit

Permalink
Remove options field from Jaeger exporter (#1808)
Browse files Browse the repository at this point in the history
The initialization options of the exporter are not used after the
Exporter is created. Stop saving them in a field.
  • Loading branch information
MrAlias authored Apr 14, 2021
1 parent 6db20e0 commit 0489060
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions exporters/trace/jaeger/jaeger.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ func NewRawExporter(endpointOption EndpointOption, opts ...Option) (*Exporter, e

e := &Exporter{
uploader: uploader,
o: o,
defaultServiceName: defaultServiceName,
}
bundler := bundler.NewBundler((*sdktrace.SpanSnapshot)(nil), func(bundle interface{}) {
Expand Down Expand Up @@ -158,7 +157,7 @@ func NewExportPipeline(endpointOption EndpointOption, opts ...Option) (trace.Tra
return nil, nil, err
}

pOpts := append(exporter.o.TracerProviderOptions, sdktrace.WithSyncer(exporter))
pOpts := append(o.TracerProviderOptions, sdktrace.WithSyncer(exporter))
tp := sdktrace.NewTracerProvider(pOpts...)
return tp, exporter.Flush, nil
}
Expand All @@ -180,7 +179,6 @@ func InstallNewPipeline(endpointOption EndpointOption, opts ...Option) (func(),
type Exporter struct {
bundler *bundler.Bundler
uploader batchUploader
o options

stoppedMu sync.RWMutex
stopped bool
Expand Down

0 comments on commit 0489060

Please sign in to comment.