Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links on NewRoot spans #1726

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 24, 2021

To ensure forwards compatibility, remove the unspecified links currently set on NewRoot spans. In resolving this the parent.GetSpanContextAndLinks was simplified to return a local or remote parent SpanContext only.

Resolves #461

To ensure forwards compatibility, remove the unspecified links currently
set on `NewRoot` spans.

Resolves #461
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #1726 (b03b02b) into main (a9b2f85) will increase coverage by 0.1%.
The diff coverage is 80.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1726     +/-   ##
=======================================
+ Coverage   77.8%   78.0%   +0.1%     
=======================================
  Files        131     131             
  Lines       6984    6955     -29     
=======================================
- Hits        5439    5426     -13     
+ Misses      1295    1279     -16     
  Partials     250     250             
Impacted Files Coverage Δ
bridge/opentracing/bridge.go 47.8% <0.0%> (+0.1%) ⬆️
internal/trace/parent/parent.go 0.0% <0.0%> (ø)
oteltest/tracer.go 90.6% <ø> (-2.4%) ⬇️
bridge/opentracing/internal/mock.go 73.6% <66.6%> (-0.7%) ⬇️
sdk/trace/span.go 90.4% <100.0%> (ø)
sdk/trace/tracer.go 87.5% <100.0%> (-1.4%) ⬇️

@Aneurysm9 Aneurysm9 merged commit 6defcfd into open-telemetry:main Mar 25, 2021
@MrAlias MrAlias deleted the fix-461 branch March 25, 2021 14:55
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better attributes for ignored parents
3 participants