-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampling parameters require a Context
with an embedded Span
#1727
Comments
I think this also ties in to the concept of a "propagation span" that only has a span context and is non-recording. I think with the |
Agreed! That is a change I am working on submitting here (which will resolve "Reconsider the context keys"). It requires this to merge first, but I think we can achieve this now. |
Remove HasRemoteParent fields from SamplingParameters. The HasRemoteParent field is a duplicate of the Remote field of the parent span context contained in the ParentContext. Change the `ParentContext` field from storing a `SpanContext` to a `context.Context` that holds the parent span. This is to conform with the OpenTelemetry specification and resolve open-telemetry#1727.
* Update SamplingParameters Remove HasRemoteParent fields from SamplingParameters. The HasRemoteParent field is a duplicate of the Remote field of the parent span context contained in the ParentContext. Change the `ParentContext` field from storing a `SpanContext` to a `context.Context` that holds the parent span. This is to conform with the OpenTelemetry specification and resolve #1727. * Update PR number
Currently we use the following sampling decision parameteres:
opentelemetry-go/sdk/trace/sampling.go
Lines 31 to 40 in 90bd4ab
The specification requires:
This likely needs to be addressed more holistically here first.
The text was updated successfully, but these errors were encountered: