-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to using go.opentelemetry.io/proto/otlp #1713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1713 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 131 131
Lines 6986 6985 -1
=====================================
+ Hits 5438 5439 +1
+ Misses 1298 1296 -2
Partials 250 250
|
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
March 19, 2021 20:56
Aneurysm9
approved these changes
Mar 19, 2021
jmacd
approved these changes
Mar 20, 2021
XSAM
approved these changes
Mar 20, 2021
Merged
MrAlias
added a commit
that referenced
this pull request
May 30, 2024
opentelemetry-proto was removed in #1713 --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com> Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
go.opentelemetry.io/proto/otlp
.github.com/gogo/protobuf
togoogle.golang.org/protobuf
to matchgo.opentelemetry.io/proto/otlp
.Resolves #1585
Resolves #1393
Resolves #1324