Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using go.opentelemetry.io/proto/otlp #1713

Merged
merged 7 commits into from
Mar 20, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 18, 2021

Changed

  • Migrate from using internally built and maintained version of the OTLP to the one hosted at go.opentelemetry.io/proto/otlp.
  • Migrate from using github.com/gogo/protobuf to google.golang.org/protobuf to match go.opentelemetry.io/proto/otlp.

Resolves #1585
Resolves #1393
Resolves #1324

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1713 (bb86538) into main (5d559b4) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1713   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        131     131           
  Lines       6986    6985    -1     
=====================================
+ Hits        5438    5439    +1     
+ Misses      1298    1296    -2     
  Partials     250     250           
Impacted Files Coverage Δ
exporters/otlp/internal/otlptest/collector.go 88.8% <ø> (ø)
exporters/otlp/internal/otlptest/otlptest.go 74.5% <ø> (ø)
exporters/otlp/internal/transform/attribute.go 91.6% <ø> (ø)
...porters/otlp/internal/transform/instrumentation.go 100.0% <ø> (ø)
exporters/otlp/internal/transform/metric.go 80.6% <ø> (ø)
exporters/otlp/internal/transform/resource.go 100.0% <ø> (ø)
exporters/otlp/internal/transform/span.go 98.1% <ø> (ø)
exporters/otlp/otlpgrpc/driver.go 90.1% <ø> (ø)
exporters/otlp/otlphttp/driver.go 93.8% <100.0%> (-0.1%) ⬇️
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review March 19, 2021 20:56
@MrAlias MrAlias merged commit 2348621 into open-telemetry:main Mar 20, 2021
@MrAlias MrAlias deleted the proto-repo branch March 20, 2021 16:25
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
MrAlias added a commit that referenced this pull request May 30, 2024
opentelemetry-proto was removed in #1713

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants