Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLTP-GRPC generator upgrade #1585

Closed
MadVikingGod opened this issue Feb 25, 2021 · 1 comment · Fixed by #1713
Closed

OLTP-GRPC generator upgrade #1585

MadVikingGod opened this issue Feb 25, 2021 · 1 comment · Fixed by #1713

Comments

@MadVikingGod
Copy link
Contributor

While working on #1122 I found that the gogo generated protobuf types are not forward compatible with the current protobuf API v2 (google.golang.org/protobuf@v1.4.0).

A solution would involve moving away from gogo to the google protobuf.

My concern with this upgrade is the performance of the generated files, what kind of performance should we measure. And, what kind of regression would be a blocker from moving to the new API?

@MrAlias
Copy link
Contributor

MrAlias commented Feb 25, 2021

@bogdandrutu can you help specify what performance metrics we should be looking at here?

We can plan to make this change after the RC if need. Also, whatever decision made here needs to be included in the new repo: https://github.com/open-telemetry/opentelemetry-proto-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants