-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP protocol support to OTLP #1122
Comments
Hi, @MrAlias , I am interested in this task. Please assign it to me, if no one has taken it. Thanks. |
@MrAlias , I setup an oltp collector which receives HTTP/JSON POST request at port
However, the collector's zpage does not show any received data, so I think there is some wrong with the request body. Could you please provide some advice on how to form a valid http/JSON content of a span. Thanks. |
I think I found some example at the receiver's test file and will give it a shot: https://github.com/open-telemetry/opentelemetry-collector/blob/e7e66939263ccbd99c9ac9352960c263d464263c/receiver/otlpreceiver/otlp_test.go#L101 |
From this ticket this duplicated: Implementation on the collector side for reference: open-telemetry/opentelemetry-collector#1021 (issue open-telemetry/opentelemetry-collector#881) Originally posted by @nilebox in #860 (comment) |
We may not need this for our RC. @punya will confirm if it is needed. |
According to https://github.com/open-telemetry/opentelemetry-specification/blob/v1.0.1/spec-compliance-matrix.md,
We already support OTLP/gRPC, so we are compliant. We can defer OTLP/HTTP to post-1.0. @MrAlias @Aneurysm9 I will remove this issue from the project and I recommend that we remove the |
Currently the OTLP exporter only export using the grpc protocol. Both the HTTP protocols required by the specification, http/json and http/protobuf, need to be supported.
Additionally, having gRPC libraries included in dependencies by default for all use of the OTLP exporter can be problematic for many users. Especially if these uses plan to use one of these HTTP protocols. When splitting out the supported protocols design thought needs to given to how we can possibly support a separated model. Possibly having a sub-module of the OTLP exporter module that contains "drivers", similar to the
database/sql/driver
, can achieve this.The text was updated successfully, but these errors were encountered: