Remove extra labels types #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstdfx
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
+ Coverage 77.9% 78.0% +0.1%
=======================================
Files 127 127
Lines 6673 6590 -83
=======================================
- Hits 5203 5146 -57
+ Misses 1223 1200 -23
+ Partials 247 244 -3
|
MrAlias
requested changes
Nov 10, 2020
There was a problem hiding this comment.
Currently this change would remove support for unspecified types when being passed from code or default to encoding them as strings. It seems like a better user experience if we could provide more relevant transformations of the passed data (e.g. float32 -> float64, uint -> int64). Making sure these transformations are well documented in the functions that will perform them is going to be crucial.
dstdfx
force-pushed
the
remove-extra-label-types
branch
2 times, most recently
from
ca6cd9f
to
e4eba8b
Compare
jmacd
approved these changes
Nov 24, 2020
XSAM
reviewed
Nov 26, 2020
dstdfx
force-pushed
the
remove-extra-label-types
branch
from
e4eba8b
to
28de50f
Compare
XSAM
approved these changes
Nov 27, 2020
dashpole
reviewed
Nov 30, 2020
dashpole
approved these changes
Dec 8, 2020
Aneurysm9
reviewed
Jan 3, 2021
dashpole
approved these changes
Jan 7, 2021
Remove the following labels types: INT32, UINT32, UINT64 and FLOAT32. Fix all extra labels types occurrences in the project. Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
dstdfx
force-pushed
the
remove-extra-label-types
branch
from
a994d82
to
51125a3
Compare
|
@MrAlias seems like I can't beat codecov/patch, could we skip this check? |
MrAlias
approved these changes
Feb 16, 2021
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Remove extra labels types Remove the following labels types: INT32, UINT32, UINT64 and FLOAT32. Fix all extra labels types occurrences in the project. Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Update CHANGELOG.md Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Delete unused helpers Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Convert passed values into remaining types Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Clarify func description * Fix uint64 convertion Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Fix uint conversion Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Update OTLP exporter label types Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1300