Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra label value types #1300

Closed
jtescher opened this issue Nov 1, 2020 · 2 comments · Fixed by #1314
Closed

Remove extra label value types #1300

jtescher opened this issue Nov 1, 2020 · 2 comments · Fixed by #1314
Assignees
Labels
pkg:API Related to an API package
Milestone

Comments

@jtescher
Copy link
Member

jtescher commented Nov 1, 2020

Currently label value types can include INT32, UINT32, UINT64, and FLOAT32 values, but the spec states that:

An Attribute MUST have the following properties:
...
The attribute value, which is either:
* A primitive type: string, boolean, double precision floating point (IEEE 754-1985) or signed 64 bit integer.
* An array of primitive type values. The array MUST be homogeneous, i.e. it MUST NOT contain values of different types.

Should we remove the extra values that are not compliant?

@MrAlias
Copy link
Contributor

MrAlias commented Nov 3, 2020

I like the idea of reducing the API surface area and conforming to the specification. 👍

@MrAlias MrAlias added pkg:API Related to an API package priority:p1 labels Nov 3, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 3, 2020
@dstdfx
Copy link
Contributor

dstdfx commented Nov 6, 2020

@MrAlias would be glad to take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:API Related to an API package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants