Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Span API event methods #1254

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Commits on Oct 13, 2020

  1. Update Span API event methods

    Remove the context argument from the event methods. It is unused and can
    be added back in as a passed option if needed in the future.
    
    Update AddEvent to accept a required name and a set of options. These
    options are the new EventOption type that can be used to configure a
    SpanConfig Timestamp and Attributes.
    
    Remove the AddEventWithTimestamp method as it is redundant to calling
    AddEvent with a WithTimestamp option.
    
    Update RecordError to also accept the EventOptions.
    MrAlias committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    cdcf586 View commit details
    Browse the repository at this point in the history
  2. Add changes to CHANGELOG

    MrAlias committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    6d3953c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e1ae677 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Configuration menu
    Copy the full SHA
    ebeb602 View commit details
    Browse the repository at this point in the history
  2. Add LifeCycleOption

    Use the LifeCycleOption to encapsulate the options passed to a span for
    life cycle events.
    MrAlias committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    4658292 View commit details
    Browse the repository at this point in the history