Update Span API event methods #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the context argument from the event methods. It is unused and can be added back in as a passed option if needed in the future. Update AddEvent to accept a required name and a set of options. These options are the new EventOption type that can be used to configure a SpanConfig Timestamp and Attributes. Remove the AddEventWithTimestamp method as it is redundant to calling AddEvent with a WithTimestamp option. Update RecordError to also accept the EventOptions.
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
========================================
- Coverage 76.4% 76.4% -0.1%
========================================
Files 132 132
Lines 5926 5928 +2
========================================
+ Hits 4532 4533 +1
- Misses 1142 1146 +4
+ Partials 252 249 -3
|
Aneurysm9
reviewed
Oct 13, 2020
Use the LifeCycleOption to encapsulate the options passed to a span for life cycle events.
Aneurysm9
approved these changes
Oct 16, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Update Span API event methods Remove the context argument from the event methods. It is unused and can be added back in as a passed option if needed in the future. Update AddEvent to accept a required name and a set of options. These options are the new EventOption type that can be used to configure a SpanConfig Timestamp and Attributes. Remove the AddEventWithTimestamp method as it is redundant to calling AddEvent with a WithTimestamp option. Update RecordError to also accept the EventOptions. * Add changes to CHANGELOG * Add LifeCycleOption Use the LifeCycleOption to encapsulate the options passed to a span for life cycle events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1103