-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new metric process.runtime.uptime
and deprecate runtime.uptime
metric in instrumentation/runtime/runtime.go
file
#5317
Open
AkhigbeEromo
wants to merge
12
commits into
open-telemetry:main
Choose a base branch
from
AkhigbeEromo:Create-a-new-metric-`process.runtime.uptime`-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
42693b4
Added `process.runtime.uptime` metric
AkhigbeEromo e7d2d4c
updated changelog
AkhigbeEromo 20335c6
Merge branch 'main' into Create-a-new-metric-`process.runtime.uptime`…
AkhigbeEromo 531cad4
Update CHANGELOG.md
AkhigbeEromo 9c8fbb9
Update CHANGELOG.md
AkhigbeEromo 5ad9cb4
Updated `uptime` metric description in `runtime.go`
AkhigbeEromo ab31814
Update instrumentation/runtime/runtime.go
AkhigbeEromo 35e28da
Merge branch 'main' into Create-a-new-metric-`process.runtime.uptime`…
AkhigbeEromo 74363f8
Merge branch 'main' into Create-a-new-metric-`process.runtime.uptime`…
AkhigbeEromo eb247c9
Merge branch 'main' into Create-a-new-metric-`process.runtime.uptime`…
AkhigbeEromo c1eb409
Merge branch 'main' into Create-a-new-metric-`process.runtime.uptime`…
AkhigbeEromo d43be19
Merge branch 'main' into Create-a-new-metric-`process.runtime.uptime`…
AkhigbeEromo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@open-telemetry/go-approvers what do you all think about this way of deprecating/renaming a metric?
It does mean for one release we emit two metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything you would like me to change @dmathieu