Create a new metric process.runtime.uptime and deprecate runtime.uptime metric in instrumentation/runtime/runtime.go file
#5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
dmathieu
reviewed
Mar 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5317 +/- ##
=======================================
- Coverage 62.3% 61.3% -1.1%
=======================================
Files 189 186 -3
Lines 11575 11261 -314
=======================================
- Hits 7221 6905 -316
- Misses 4145 4156 +11
+ Partials 209 200 -9
|
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dmathieu
reviewed
Mar 20, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
…-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
…-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
dmathieu
reviewed
Mar 25, 2024
| @@ -111,6 +111,15 @@ func (r *runtime) register() error { | |||
| uptime, err := r.meter.Int64ObservableCounter( | |||
| "runtime.uptime", | |||
| metric.WithUnit("ms"), | |||
| metric.WithDescription("Milliseconds since application was initialized. Deprecated metric. Use `process.runtime.runtime` instead."), | |||
There was a problem hiding this comment.
@open-telemetry/go-approvers what do you all think about this way of deprecating/renaming a metric?
It does mean for one release we emit two metrics.
There was a problem hiding this comment.
Is there anything you would like me to change @dmathieu
…-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
…-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
|
Hello @dmathieu, any update on this PR? Or is there anything you would like me to change? |
…-and-deprecate-`runtime.uptime`-metric-in-`instrumentation/runtime/runtime.go`-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.runtime.uptimeand made it an asynchronous gauge function.runtime.uptimemetric