Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove high cardanility metrics from otelhttp #4277

Merged
merged 9 commits into from
Sep 7, 2023

use switch over map lookup

417cf57
Select commit
Loading
Failed to load commit list.
Merged

Remove high cardanility metrics from otelhttp #4277

use switch over map lookup
417cf57
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 6, 2023 in 0s

77.3% (-2.2%) compared to 417fc12

View this Pull Request on Codecov

77.3% (-2.2%) compared to 417fc12

Details

Codecov Report

Merging #4277 (417cf57) into main (417fc12) will decrease coverage by 2.2%.
Report is 3 commits behind head on main.
The diff coverage is 6.8%.

❗ Current head 417cf57 differs from pull request most recent head 5a3f48f. Consider uploading reports for the commit 5a3f48f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4277     +/-   ##
=======================================
- Coverage   79.4%   77.3%   -2.2%     
=======================================
  Files        166     166             
  Lines      10363   10663    +300     
=======================================
+ Hits        8233    8246     +13     
- Misses      1996    2283    +287     
  Partials     134     134
Files Changed Coverage
...stful/otelrestful/internal/semconvutil/httpconv.go 6.8%
...gonic/gin/otelgin/internal/semconvutil/httpconv.go 6.8%
...rilla/mux/otelmux/internal/semconvutil/httpconv.go 6.8%
...ack/echo/otelecho/internal/semconvutil/httpconv.go 6.8%
...on.v1/otelmacaron/internal/semconvutil/httpconv.go 6.8%
...ace/otelhttptrace/internal/semconvutil/httpconv.go 6.8%
...net/http/otelhttp/internal/semconvutil/httpconv.go 6.8%
View more details on Codecov