Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove high cardanility metrics from otelhttp #4277

Merged
merged 9 commits into from
Sep 7, 2023

use switch over map lookup

417cf57
Select commit
Loading
Failed to load commit list.
Merged

Remove high cardanility metrics from otelhttp #4277

use switch over map lookup
417cf57
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 6, 2023 in 0s

6.8% of diff hit (target 79.4%)

View this Pull Request on Codecov

6.8% of diff hit (target 79.4%)

Annotations

Check warning on line 392 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L374-L392

Added lines #L374 - L392 were not covered by tests

Check warning on line 407 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L394-L407

Added lines #L394 - L407 were not covered by tests

Check warning on line 409 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L409

Added line #L409 was not covered by tests

Check warning on line 424 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L419-L424

Added lines #L419 - L424 were not covered by tests

Check warning on line 426 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L426

Added line #L426 was not covered by tests

Check warning on line 392 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L374-L392

Added lines #L374 - L392 were not covered by tests

Check warning on line 407 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L394-L407

Added lines #L394 - L407 were not covered by tests

Check warning on line 409 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L409

Added line #L409 was not covered by tests

Check warning on line 424 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L419-L424

Added lines #L419 - L424 were not covered by tests

Check warning on line 426 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L426

Added line #L426 was not covered by tests

Check warning on line 392 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L374-L392

Added lines #L374 - L392 were not covered by tests

Check warning on line 407 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L394-L407

Added lines #L394 - L407 were not covered by tests

Check warning on line 409 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L409

Added line #L409 was not covered by tests

Check warning on line 424 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L419-L424

Added lines #L419 - L424 were not covered by tests

Check warning on line 426 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L426

Added line #L426 was not covered by tests

Check warning on line 392 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L374-L392

Added lines #L374 - L392 were not covered by tests

Check warning on line 407 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L394-L407

Added lines #L394 - L407 were not covered by tests

Check warning on line 409 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L409

Added line #L409 was not covered by tests

Check warning on line 424 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L419-L424

Added lines #L419 - L424 were not covered by tests

Check warning on line 426 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L426

Added line #L426 was not covered by tests

Check warning on line 392 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L374-L392

Added lines #L374 - L392 were not covered by tests

Check warning on line 407 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L394-L407

Added lines #L394 - L407 were not covered by tests

Check warning on line 409 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L409

Added line #L409 was not covered by tests

Check warning on line 424 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L419-L424

Added lines #L419 - L424 were not covered by tests

Check warning on line 426 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L426

Added line #L426 was not covered by tests