Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semconvgen: Quickfix after semconv repo migration #374

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 25, 2023

This is "quickfix" for semconvgen so that the OTel Collector and Go can use semconvgen after the semantic conventions moved from https://github.com/open-telemetry/opentelemetry-specification to https://github.com/open-telemetry/semantic-conventions.

This change was tested as part of open-telemetry/opentelemetry-go#4362

A more sophisticated way would be probably to have two args in semconvgen; one for the Git repository and second for folder when the YAML definitions reside. However, I think that it may be not worth the effort and could introduce more problems than benefits (both OTel Collector and Go would need to update their semconv generation scripts).

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (37d80b2) 62.07% compared to head (a864199) 62.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   62.07%   62.07%           
=======================================
  Files          48       48           
  Lines        2344     2344           
=======================================
  Hits         1455     1455           
  Misses        741      741           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared marked this pull request as ready for review July 25, 2023 10:54
@pellared pellared requested review from a team and djaglowski July 25, 2023 10:54
@pellared pellared changed the title semconvgen: Quickfix after semconv migration semconvgen: Quickfix after semconv repo migration Jul 25, 2023
.chloggen/semconvgen-quickfix.yaml Outdated Show resolved Hide resolved
.chloggen/semconvgen-quickfix.yaml Outdated Show resolved Hide resolved
pellared and others added 2 commits July 25, 2023 19:05
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared merged commit 84875ac into open-telemetry:main Jul 26, 2023
@pellared pellared mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants