-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semconv/v1.21.0 #4362
Add semconv/v1.21.0 #4362
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4362 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 184 184
Lines 14383 14383
=====================================
+ Hits 12002 12004 +2
+ Misses 2153 2151 -2
Partials 228 228 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you given a look to upgrading all use of semconv
in this repo and contrib to these changes? Are we missing any thing in the generation to accomplish this?
Are you planning to upgrade semconv
in follow PRs?
I have not found anything missing. Is there anything special that I should double-check?
I created a separate issue #4364 to address this. |
Nothing seems obvious to me in glancing over this, but I haven't tried the upgrade. I was just wondering given the shuffle upstream and the fact that we don't generate everything if we missed something. If you've already taken a look at the upgrade that's good enough for me. |
Hi @mehdihadeli See: Line 80 in 9bbefc6
It was as designed and planned as part of #4081 If you want you can copy-paste (or generate the code like we do e.g. here) the code from https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/internal/shared/semconvutil |
Can I use |
Fixes #4355
I had to make a little change in
semconvgen
to make the generation working open-telemetry/opentelemetry-go-build-tools#374 as the folder were the YAML files changed.