[otlp] Update README for UseOtlpExporter & new experimental flag #5452
Lint.
- Loading branch information
commit b5d88d1b79e94d1b722b8518c0d214427c052291
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -633,7 +633,7 @@ | |
| * All signals | ||
|
|
||
| * `OTEL_DOTNET_EXPERIMENTAL_OTLP_ENABLE_INMEMORY_RETRY` | ||
|
|
||
|
Check failure on line 636 in src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md
|
||
| When set to `true`, it enables in-memory retry for transient errors | ||
| encountered while sending telemetry. | ||
|
|
||
|
|
@@ -642,7 +642,7 @@ | |
| * Logs | ||
|
|
||
| * `OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES` | ||
|
|
||
| When set to `true`, it enables export of `LogRecord.EventId.Id` as | ||
| `logrecord.event.id` and `LogRecord.EventId.Name` as `logrecord.event.name`. | ||
CodeBlanch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishweshbankwar I have questions regarding the name - does it mean later there will be something like "OTLP_ENABLE_ONDISK_RETRY
? What's the thinking which leads to the current name instead ofOTEL_DOTNET_EXPERIMENTAL_OTLP_ENABLE_RETRY`?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the thinking. Wanted to have decoupled experimental environment variables.
When we move to stable, I would like it to be
OTEL_DOTNET_OTLP_ENABLE_RETRYand define possible values for it likeinmemoryanddisk.