Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Update README for UseOtlpExporter & new experimental flag #5452

Merged
merged 17 commits into from
Mar 21, 2024
Merged

[otlp] Update README for UseOtlpExporter & new experimental flag #5452

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0c8d633
Update OtlpExporter README for UseOtlpExporter & OTEL_DOTNET_EXPERIME…
CodeBlanch Mar 14, 2024
c4e8ee4
Lint.
CodeBlanch Mar 14, 2024
48d300d
Code review.
CodeBlanch Mar 15, 2024
a71bc61
Lint.
CodeBlanch Mar 15, 2024
841175e
Add metrics config example.
CodeBlanch Mar 15, 2024
31e6f2f
Code review.
CodeBlanch Mar 15, 2024
ba1fac9
Tweaks.
CodeBlanch Mar 15, 2024
d5609a9
Code review.
CodeBlanch Mar 18, 2024
9a35880
Tweak.
CodeBlanch Mar 18, 2024
727012a
Code review and tweaks.
CodeBlanch Mar 19, 2024
b5d88d1
Lint.
CodeBlanch Mar 19, 2024
ae79059
Merge branch 'main' into otlp-exporter-doc-updates
CodeBlanch Mar 19, 2024
b21da4b
Code review.
CodeBlanch Mar 19, 2024
452c40b
Lint.
CodeBlanch Mar 19, 2024
2142ecb
Code review.
CodeBlanch Mar 20, 2024
92ed619
Merge remote-tracking branch 'upstream/main' into otlp-exporter-doc-u…
CodeBlanch Mar 21, 2024
8e2e25a
Code review.
CodeBlanch Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Mar 19, 2024
commit 452c40b0c3ca5abc14a8a53a723f36ae8469b6fa
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ want to solicit feedback from the community.
* All signals

* `OTEL_DOTNET_EXPERIMENTAL_OTLP_ENABLE_INMEMORY_RETRY`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishweshbankwar I have questions regarding the name - does it mean later there will be something like "OTLP_ENABLE_ONDISK_RETRY? What's the thinking which leads to the current name instead of OTEL_DOTNET_EXPERIMENTAL_OTLP_ENABLE_RETRY`?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it mean later there will be something like "OTLP_ENABLE_ONDISK_RETRY

That was the thinking. Wanted to have decoupled experimental environment variables.

When we move to stable, I would like it to be OTEL_DOTNET_OTLP_ENABLE_RETRY and define possible values for it like inmemory and disk.


When set to `true`, it enables in-memory retry for transient errors
encountered while sending telemetry.

Expand Down