-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HttpSemanticConvention breaking changes (part2) #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4514 +/- ##
==========================================
+ Coverage 85.13% 85.15% +0.01%
==========================================
Files 318 318
Lines 12615 12620 +5
==========================================
+ Hits 10740 10746 +6
+ Misses 1875 1874 -1
|
utpilla
reviewed
May 24, 2023
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs
Show resolved
Hide resolved
utpilla
approved these changes
May 24, 2023
pellared
approved these changes
May 25, 2023
This comment was marked as resolved.
This comment was marked as resolved.
vishweshbankwar
approved these changes
May 25, 2023
vitek-karas
pushed a commit
to vitek-karas/opentelemetry-dotnet
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design discussion issue #4484
Follow up to #4504
Http Semantic Convention is introducing breaking changes.
The previous PR updated the AspNetCore instrumentation project's listener to get the value from the environment variable.
This PR updates the remaining affected projects.
Future PRs will contribute the actual implementation.
Changes
Instrumentation.AspNetCore
HttpInMetricsListener
ctorInstrumentation.GrpcNetClient
GrpcClientDiagnosticListener
ctorInstrumentation.Http
HttpHandlerDiagnosticListener
ctorHttpHandlerMetricsDiagnosticListener
ctorInstrumentation.SqlClient
SqlClientDiagnosticListener
ctorPlease provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes@vishweshbankwar please review