Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HttpSemanticConvention breaking changes (part2) #4514

Merged
merged 5 commits into from
May 25, 2023
Merged

Add support for HttpSemanticConvention breaking changes (part2) #4514

merged 5 commits into from
May 25, 2023

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented May 24, 2023

Design discussion issue #4484
Follow up to #4504

Http Semantic Convention is introducing breaking changes.
The previous PR updated the AspNetCore instrumentation project's listener to get the value from the environment variable.
This PR updates the remaining affected projects.

Future PRs will contribute the actual implementation.

Changes

  • Update Instrumentation.AspNetCore
    • HttpInMetricsListener ctor
  • Update Instrumentation.GrpcNetClient
    • GrpcClientDiagnosticListener ctor
  • Update Instrumentation.Http
    • HttpHandlerDiagnosticListener ctor
    • HttpHandlerMetricsDiagnosticListener ctor
  • Update Instrumentation.SqlClient
    • SqlClientDiagnosticListener ctor

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar please review

@TimothyMothra TimothyMothra requested a review from a team May 24, 2023 20:22
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #4514 (03ffa5a) into main (f247758) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4514      +/-   ##
==========================================
+ Coverage   85.13%   85.15%   +0.01%     
==========================================
  Files         318      318              
  Lines       12615    12620       +5     
==========================================
+ Hits        10740    10746       +6     
+ Misses       1875     1874       -1     
Impacted Files Coverage Δ
...AspNetCore/Implementation/HttpInMetricsListener.cs 75.00% <100.00%> (+0.64%) ⬆️
...ent/Implementation/GrpcClientDiagnosticListener.cs 86.88% <100.00%> (+0.21%) ⬆️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 74.48% <100.00%> (+0.26%) ⬆️
...ementation/HttpHandlerMetricsDiagnosticListener.cs 95.45% <100.00%> (+0.21%) ⬆️
...ient/Implementation/SqlClientDiagnosticListener.cs 85.18% <100.00%> (+0.18%) ⬆️

... and 3 files with indirect coverage changes

@TimothyMothra

This comment was marked as resolved.

@utpilla utpilla merged commit 601485d into open-telemetry:main May 25, 2023
@TimothyMothra TimothyMothra deleted the 4484_httpSemConv2 branch May 25, 2023 23:47
vitek-karas pushed a commit to vitek-karas/opentelemetry-dotnet that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants