Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http instrumentation libraries stable release plan #4484

Closed
vishweshbankwar opened this issue May 12, 2023 · 4 comments
Closed

Http instrumentation libraries stable release plan #4484

vishweshbankwar opened this issue May 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@vishweshbankwar
Copy link
Member

vishweshbankwar commented May 12, 2023

open-telemetry/opentelemetry-specification#3443 lays out the detailed plan for stabilizing the http instrumentation libraries.

PRs that include major changes
open-telemetry/opentelemetry-specification#3402
open-telemetry/opentelemetry-specification#3426
open-telemetry/opentelemetry-specification#3355

For .NET, we will proceed as follows

  1. Update the following instrumentation libraries to look up OTEL_SEMCONV_STABILITY_OPT_IN environment variable and set the attributes as per the values specified in spec.
  • OpenTelemetry.Instrumentation.AspNetCore
  • OpenTelemetry.Instrumentation.Http
  • OpenTelemetry.Instrumentation.SqlClient
  • OpenTelemetry.Instrumentation.GrpcNetClient

Note: The change impacts all the above libraries due to updates in networking attributes open-telemetry/opentelemetry-specification#3402

  1. Release the RC version with the above mentioned changes.

  2. Drop OTEL_SEMCONV_STABILITY_OPT_IN environment variable from OpenTelemetry.Instrumentation.AspNetCore and OpenTelemetry.Instrumentation.Http in the final RC version.

Note: Other libraries should continue to look up the environment variable.

  1. Release stable 1.0.0 version of OpenTelemetry.Instrumentation.AspNetCore and OpenTelemetry.Instrumentation.Http.
@TimothyMothra
Copy link
Contributor

FYI: this doc is useful for tracking changes to the conventions:
https://github.com/open-telemetry/opentelemetry-specification/blob/v1.22.0/schemas/1.21.0

@TimothyMothra
Copy link
Contributor

FYI.
Semantic-Conventions repo is readying their first release. The version will be v1.21.0. No ETA because they're building out the processes.
https://github.com/open-telemetry/semantic-conventions/blob/df8e53054147acf49918582bd446d0f524170071/CHANGELOG.md

Trask advised that we should link to "main" for now.

I will create a new PR to correct everything that merged already.

@danelson
Copy link
Contributor

danelson commented Sep 5, 2023

Are there any plans to publish the schema url? Is that something that would happen here or in the runtime? Consuming this data from many different language SDKs across different versions of those SDKs becomes an issue when querying data in various backends. I would love to start using the schema processor to help alleviate this but the schema url needs to be available.

@cijothomas
Copy link
Member

Are there any plans to publish the schema url? Is that something that would happen here or in the runtime? Consuming this data from many different language SDKs across different versions of those SDKs becomes an issue when querying data in various backends. I would love to start using the schema processor to help alleviate this but the schema url needs to be available.

Not possible until this is done : #2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants