-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Introduce common url.*
attributes, and improve use of namespacing under http.*
#3355
Conversation
hey @lmolkova, there was a request in the Spec SIG today that we remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking temporarily to make sure we agree on #3362 before the breaking changes are done.
The work on this PR can of course continue, I just want to prevent merging this prematurely.
84ca0c3
to
de0f78e
Compare
I have two general questions: 1. Making HTTP attributes signal agnosticCurrently only a very small subset of HTTP attributes is signal agnostic as defined in the 2. Missing ECS fieldsThere is a bunch of Missing HTTP fields
Missing URL fields
Do you think it makes sense to adopt these fields in this PR as well (as part of "Adopt ECS attributes in HTTP semantic conventions")? Otherwise, we can create a separate PR to add these fields. |
We removed lots of redundant fields in the HTTP conventions #2469. The fields you mention @AlexanderWert seem to define alternative URL splits, which seems to go in the opposite direction. Is there a general policy for our ECS alignment I could refer to, to see what our goals are with this alignment and how far and in which direction we can align? The only thing I'm wondering about is |
…espacing under `http.*` (open-telemetry#3355)
Adopts ECS some of HTTP and URL attributes according to proposal in #3163
Resolves #3181
Resolves #3182
Resolves #3439
Resolves #2028
HTTP:
http.method
->http.request.method
http.status_code
->http.response.status_code
http.request_content_length
->http.request.body.size
http.response_content_length
->http.response.body.size
http.url
->url.full
http.target
->url.path
+url.query
http.scheme
->url.scheme
http.client_ip
-> not in this PRhttp.route
-> no changehttp.resend_count
-> no changehttp.request.header.<key>
- no changehttp.response.header.<key>
- no change[Update] Removed exception and network attributes from this PR - need more discussion
Summary of benefits
url.*
- avoids adding separate fields for separate URL types, and makes it easier to correlate telemetry across different URL types (e.g. ftp://, ssh://, file://, data://, etc).http.request.*
andhttp.response.*
- consistent namespacing and avoids breaking ECS (and we are already proposing to break thehttp.*
namespace in bigger ways on the OpenTelemetry side)