Use default Batch if no metrics are available to collect #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Sep 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #2391 +/- ##
=======================================
Coverage 79.95% 79.96%
=======================================
Files 231 231
Lines 7440 7441 +1
=======================================
+ Hits 5949 5950 +1
Misses 1491 1491
|
CodeBlanch
reviewed
Sep 21, 2021
| { | ||
| this.metrics[i].SnapShot(); | ||
| } | ||
|
|
||
| return new Batch<Metric>(this.metrics, indexSnapShot + 1); | ||
| return (target > 0) ? new Batch<Metric>(this.metrics, indexSnapShot + 1) : default; |
There was a problem hiding this comment.
nit: Looks like you could use target in here too (instead of indexSnapShot + 1): new Batch<Metric>(this.metrics, target)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock https://github.com/open-telemetry/opentelemetry-dotnet/pull/2389/files by addressing #2390