Use default Batch if no metrics are available to collect (#2391)

open-telemetry · Sep 21, 2021 · 29110dc · 29110dc
1 parent 47e1c5e
commit 29110dc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/OpenTelemetry/Metrics/MeterProviderSdk.cs b/src/OpenTelemetry/Metrics/MeterProviderSdk.cs
@@ -167,12 +167,13 @@ internal Batch<Metric> Collect()
                     // Record all observable instruments
                     this.listener.RecordObservableInstruments();
                     var indexSnapShot = Math.Min(this.metricIndex, MaxMetrics - 1);
-                    for (int i = 0; i < indexSnapShot + 1; i++)
+                    var target = indexSnapShot + 1;
+                    for (int i = 0; i < target; i++)
                     {
                         this.metrics[i].SnapShot();
                     }
 
-                    return new Batch<Metric>(this.metrics, indexSnapShot + 1);
+                    return (target > 0) ? new Batch<Metric>(this.metrics, indexSnapShot + 1) : default;
                 }
                 catch (Exception)
                 {