[featureflag] - use full demo protos #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tsloughter
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
@puckpuck thanks! This looks good. All the extra modules is why I was waiting to do this -- and the fact the ffs_demo_pb module is now huge. But looking at this PR it seems that new module is only 7k lines and the old 2k, so not bad and not an issue.
I would suggest using a symlink to link to the top level demo.proto if possible -- I think Windows supports those now? -- otherwise I'll focus on making a change to the grpc server generator to support reading files from parent directories.
|
I created #279 to track updating Dockerfile for this service |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #245
Changes
Uses a full copy of the
demo.prototo build corresponding gRPC modules. Previously we were using a small subset ofdemo.protowithout thepackage hipstershopdeclaration. There are several new files in this PR because we are now building the Erlang behavior modules for all the services part of the protobuf definition. This can be addressed in another PR to clean up the docker build process for this service.For significant contributions please make sure you have completed the following items:
Does this PR require a changelog update?
CHANGELOG.mdupdated for non-trivial changes