[productcatalog] - generate error on feature flag #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docker-compose.yml
1 task
|
After we merge #271 I'll update this branch from the base branch. |
# Conflicts: # .env
|
Can we have some user documentation for enabling this or will it be automatically set up soon after we merge this pr in a subsequent pr? |
That will come in a subsequent PR which also adds the actual feature flags to the database when the feature flag service starts. |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Generates an error on a specific product when a feature flag is enabled.
related issue: #162
Currently, this PR will not work since we have an issue that needs resolving with the feature flag service. Once that is resolved, we can finalize this PR.
For significant contributions please make sure you have completed the following items:
I will update the changelog after we resolve feature flag service communication issues
CHANGELOG.mdupdated for non-trivial changes