Add OStreamSpanExporter #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests build and pass when running locally and in docker container but fail in this CI jobs, looking into it |
|
Renamed to OStreamSpanExporter. Also added setting the TraceID / SpanID in tests so the tests do not break when IDs begin to be randomly generated. This is rebased with master as well |
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
reyang
reviewed
Jul 21, 2020
reyang
reviewed
Jul 21, 2020
|
Thanks for the feedback @reyang let me know if I missed anything |
reyang
reviewed
Jul 21, 2020
| void printAttributes(std::unordered_map<std::string, sdktrace::SpanDataAttributeValue> map) | ||
| { | ||
| int size = map.size(); | ||
| int num = 1; |
There was a problem hiding this comment.
Renamed to i. This branch is merged this master already
reyang
added
the
pr:please-merge
|
Design document can be found here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the span half of the StreamExporter described in issue (#89). This exporter will not be used in production code, but rather in explorations or examples. This SpanExporter takes data in from the SpanProcessor in the form of recordables. The exporter then takes the recordables and gets all of the relevant data out of it and sends it to an ostream. The default configuration is to send the recordable data to stdout. The StreamMetricsExporter will be included in a future PR.
This PR includes tests for cout, cerr and clog as well as the shutdown function.
This PR also replaces the stub stdout_exporter in the simple tracing example (#86)