Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON formatting to OStreamExporters #202

Open
HudsonHumphries opened this issue Jul 22, 2020 · 6 comments
Open

Add JSON formatting to OStreamExporters #202

HudsonHumphries opened this issue Jul 22, 2020 · 6 comments
Labels

Comments

@HudsonHumphries
Copy link
Member

HudsonHumphries commented Jul 22, 2020

Is your feature request related to a problem?
There is currently no way for the user to change the format that OStreamExporters export the data. If the user wants to send their data directly to a json file, it will not be in the correct format.

Describe the solution you'd like
Have the user pass in a boolean for json printing in the constructor. Then in export() format the data what the user has specified. Since the user won't directly call export() it makes sense to pass the boolean in the constructor.

Describe alternatives you've considered
An alternative is to support json formatting as the default and only printing. This doesn't seem ideal as most users will only print to stdout and will have a harder time reading the output.

Additional context
The two exporters are 218 and 183

@pyohannes pyohannes added area:exporter enhancement New feature or request labels Jul 22, 2020
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 30, 2021
@deejgregor
Copy link
Contributor

I started working on this in #1111.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Closed as inactive. Feel free to reopen if this is still an issue.

@github-actions github-actions bot closed this as completed Feb 9, 2022
@lalitb lalitb reopened this Feb 9, 2022
@lalitb lalitb added do-not-stale and removed Stale labels Feb 9, 2022
@yinfangchen
Copy link

Does Otel support the JSON output now? @lalitb @deejgregor
Thanks.

@owent
Copy link
Member

owent commented Jan 10, 2024

Does Otel support the JSON output now? @lalitb @deejgregor Thanks.

Not yet, I create #2482 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants