Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated clone command in INSTALL.md #1818

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Conversation

paul-ohl
Copy link
Contributor

Fixes # (issue)

Changes

Since version 2.13 of git, the --recursive flag has been replaced by --recurse-submodules. So I updated the INSTALL.md file to reflect that change.

See this issue for details.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

I don't consider this contribution to be significant enough to add into CHANGELOG.md.

Since version 2.13 of git, the `--recursive` flag has been replaced by `--recurse-submodules`.

See [this issue](https://stackoverflow.com/questions/3796927/how-do-i-git-clone-a-repo-including-its-submodules) for details.
@paul-ohl paul-ohl requested a review from a team November 28, 2022 21:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: paul-ohl / name: Paul Ohl (405b26b)
  • ✅ login: ThomsonTan / name: Tom Tan (6f59cd8)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix. CLA needs to be signed before this can be merged.

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Nov 29, 2022
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on CLA

@ThomsonTan
Copy link
Contributor

Thanks for he fix. It looks good to me. Just curious, the option --recursive seems still available after git v2.13 and is an alias of --recurse-submodule?

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1818 (b1206cb) into main (f3daca0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1818   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         171      171           
  Lines        5240     5240           
=======================================
  Hits         4492     4492           
  Misses        748      748           

@paul-ohl
Copy link
Contributor Author

Yes it does actually, I must have ran the command wrong the first time ><

I thought I was doing a meaningful fix, but no, I just made a mistake that I forgot about, sorry.

I guess it's still useful to have the last version of the command in the documentation? It's your decision.

@ThomsonTan
Copy link
Contributor

Yes it does actually, I must have ran the command wrong the first time ><

I thought I was doing a meaningful fix, but no, I just made a mistake that I forgot about, sorry.

I guess it's still useful to have the last version of the command in the documentation? It's your decision.

Thanks! The new option looks good as it is more explicit about the impact on submodule. Can you please sign the CLA to get this PR merged?

@esigo esigo added the area:docs Documentation label Dec 1, 2022
@lalitb lalitb removed the pr:waiting-on-cla Waiting on CLA label Dec 2, 2022
@lalitb lalitb enabled auto-merge (squash) December 12, 2022 17:25
@lalitb lalitb merged commit 9712161 into open-telemetry:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants