-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated clone command in INSTALL.md #1818
Conversation
Since version 2.13 of git, the `--recursive` flag has been replaced by `--recurse-submodules`. See [this issue](https://stackoverflow.com/questions/3796927/how-do-i-git-clone-a-repo-including-its-submodules) for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix. CLA needs to be signed before this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting on CLA
Thanks for he fix. It looks good to me. Just curious, the option |
Yes it does actually, I must have ran the command wrong the first time >< I thought I was doing a meaningful fix, but no, I just made a mistake that I forgot about, sorry. I guess it's still useful to have the last version of the command in the documentation? It's your decision. |
Thanks! The new option looks good as it is more explicit about the impact on submodule. Can you please sign the CLA to get this PR merged? |
Fixes # (issue)
Changes
Since version 2.13 of git, the
--recursive
flag has been replaced by--recurse-submodules
. So I updated theINSTALL.md
file to reflect that change.See this issue for details.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changesI don't consider this contribution to be significant enough to add into
CHANGELOG.md
.