Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nostd::span as dependency from Dependency document #1260

Merged
merged 5 commits into from
Mar 13, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Mar 11, 2022

Fixes #1230

Changes

Have validated the two components nostd::span and std::variant. None of these have been copied ( read - lift and shift) directly from the libstd implementation. They have been written to ensure that the ABI compatibility is maintained with libstdc++. The code has been compared with libstd library here and here, and also confirmed with the contributor of std::variant in this repo.

The dependency document has been updated to remove nostd::span as internal dependency.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team March 11, 2022 00:26
@lalitb lalitb changed the title Modify nostd::span license information in dependency document Remove nostd::span as dependency from Dependency document Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1260 (4ca0b53) into main (da94697) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         202      202           
  Lines        7336     7336           
=======================================
  Hits         6776     6776           
  Misses        560      560           

@lalitb lalitb merged commit 49648bd into open-telemetry:main Mar 13, 2022
DebajitDas pushed a commit to DebajitDas/opentelemetry-cpp that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPL License for dependencies
2 participants