Skip to content

Commit

Permalink
AttributesProcessor dtor (#1263)
Browse files Browse the repository at this point in the history
  • Loading branch information
esigo authored Mar 13, 2022
1 parent 28bd621 commit da94697
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ class AttributesProcessor
// @returns The processed attributes
virtual MetricAttributes process(
const opentelemetry::common::KeyValueIterable &attributes) const noexcept = 0;

virtual ~AttributesProcessor() = default;
};

/**
Expand Down

2 comments on commit da94697

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: da94697 Previous: 28bd621 Ratio
BM_NaiveSpinLockThrashing/2/process_time/real_time 1.2152113326608318 ms/iter 0.333893144285524 ms/iter 3.64

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: da94697 Previous: 28bd621 Ratio
BM_BaselineBuffer/2 9108052.253723145 ns/iter 3335452.5566101074 ns/iter 2.73

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.