Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CMakeLists.txt: Enable CMAKE_MSVC_RUNTIME_LIBRARY support (#2652)
The documentation for CMAKE_MSVC_RUNTIME_LIBRARY states [1]: > This variable has effect only when policy CMP0091 is set to NEW prior to > the first project() or enable_language() command that enables a language > using a compiler targeting the MSVC ABI. so the current usage of CMAKE_MSVC_RUNTIME_LIBRARY for vcpkg does not work at all. Let's fix that by setting policy 91 to new if present. [1]: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html Co-authored-by: Tom Tan <Tom.Tan@microsoft.com>
- Loading branch information
436a981
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.BM_MeasurementsTest
10029368.40057373
ns/iter2820069.5514678955
ns/iter3.56
This comment was automatically generated by workflow using github-action-benchmark.
436a981
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.BM_SpinLockThrashing/4/process_time/real_time
4.105503559112549
ms/iter0.6907526495421461
ms/iter5.94
BM_NaiveSpinLockThrashing/4/process_time/real_time
1.6993927955627441
ms/iter0.6749223260318532
ms/iter2.52
BM_ThreadYieldSpinLockThrashing/4/process_time/real_time
121.60563468933105
ms/iter57.747721672058105
ms/iter2.11
This comment was automatically generated by workflow using github-action-benchmark.