Skip to content

Commit

Permalink
[BUILD] Remove the incorrect set of CMAKE_MSVC_RUNTIME_LIBRARY for vc…
Browse files Browse the repository at this point in the history 
…pkg (#2696)
  • Loading branch information
@ThomsonTan
ThomsonTan authored Jun 6, 2024
1 parent bf8fa53 commit 1d8a7b5
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,6 @@ if(MSVC)
# __cplusplus flag is not supported by Visual Studio 2015
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:__cplusplus")
endif()
# When using vcpkg, all targets build with the same runtime
if(VCPKG_TOOLCHAIN)
set(CMAKE_MSVC_RUNTIME_LIBRARY
"MultiThreaded$<$<CONFIG:Debug>:Debug>$<$<STREQUAL:${VCPKG_CRT_LINKAGE},dynamic>:DLL>"
CACHE STRING "")
endif()
endif()

# include GNUInstallDirs before include cmake/opentelemetry-proto.cmake because
Expand Down

2 comments on commit 1d8a7b5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1d8a7b5 Previous: bf8fa53 Ratio
BM_LockFreeBuffer/1 8673102.855682373 ns/iter 2243971.347808838 ns/iter 3.87
BM_HistogramAggregation 11191255.906048942 ns/iter 4327629.551743016 ns/iter 2.59

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1d8a7b5 Previous: bf8fa53 Ratio
BM_SpanIdToLowerBase16 13.956494072883679 ns/iter 6.4988834934798865 ns/iter 2.15
BM_SpanIdIsValid 1.3259147920486054 ns/iter 0.6204829380831575 ns/iter 2.14

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.