Skip to content

Commit

Permalink
[BUILD] Remove benchmark overlay for vcpkg (#2695)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ThomsonTan
ThomsonTan authored Jun 6, 2024
1 parent cb9cd1d commit bf8fa53
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 57 deletions.
36 changes: 0 additions & 36 deletions ci/ports/benchmark/portfile.cmake
View file

This file was deleted.

19 changes: 0 additions & 19 deletions ci/ports/benchmark/vcpkg.json
View file

This file was deleted.

4 changes: 2 additions & 2 deletions ci/setup_windows_ci_environment.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ $VCPKG_DIR = (Get-Item -Path ".\").FullName
./bootstrap-vcpkg.bat
./vcpkg integrate install

# Patched Google Benchmark can be shared between vs2017 and vs2019 compilers
./vcpkg "--vcpkg-root=$VCPKG_DIR" install --overlay-ports="$PSScriptRoot\ports" benchmark:x64-windows
# Google Benchmark
./vcpkg "--vcpkg-root=$VCPKG_DIR" install benchmark:x64-windows

# Google Test
./vcpkg "--vcpkg-root=$VCPKG_DIR" install gtest:x64-windows
Expand Down

2 comments on commit bf8fa53

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bf8fa53 Previous: cb9cd1d Ratio
BM_BaselineBuffer/2 10914859.771728516 ns/iter 2735994.1426445455 ns/iter 3.99
BM_BaselineBuffer/4 14307951.927185059 ns/iter 2652660.012245178 ns/iter 5.39
BM_LockFreeBuffer/2 5994420.051574707 ns/iter 1191196.1611579447 ns/iter 5.03
BM_LockFreeBuffer/4 10552685.260772705 ns/iter 1322929.3778988158 ns/iter 7.98

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bf8fa53 Previous: cb9cd1d Ratio
BM_SpinLockThrashing/2/process_time/real_time 0.9141980785213105 ms/iter 0.2129097850804118 ms/iter 4.29

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.